Open
Conversation
adamtheturtle
had a problem deploying
to
development
GitHub Actions
Failure
adamtheturtle
had a problem deploying
to
development
GitHub Actions
Failure
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
adamtheturtle
force-pushed
the
adamtheturtle/add-vumark-support
branch
from
320a02f to
eab90e0
Compare
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
adamtheturtle
force-pushed
the
adamtheturtle/add-vumark-support
branch
from
3ca29d8 to
9d43056
Compare
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
adamtheturtle
force-pushed
the
adamtheturtle/add-vumark-support
branch
from
c419a37 to
a137ce7
Compare
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The `vumark` command is now its own binary/entrypoint, following the same pattern as `vuforia-cloud-reco`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mock-vws does not yet handle unknown targets or target status validation for VuMark generation. Mark those tests as expected failures and exclude untestable error paths from coverage. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… calls Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mock-vws now handles VuMark generation and unknown target errors, so the monkeypatching workarounds are no longer needed. Add vumark_database, vumark_target, and vumark_client fixtures to conftest. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…bility The [tool.pytest] section (introduced by main's a30cb99 commit) was wrong and should be [tool.pytest.ini_options]. Also add --capture=no to avoid a conflict between pytest's stdout/stderr capture and Click 8.3.1's CliRunner StreamMixer, which causes ValueError: I/O operation on closed file. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove the private _get_vumark_error_message helper and its unit tests. The three testable error paths (UnknownTargetError, InvalidInstanceIdError, TargetStatusNotSuccessError) are now tested via CliRunner. Remaining error paths are grouped under a single pragma: no cover branch. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rowing Pylint does not narrow the type of `exc` from `VWSError | ServerError` to the specific subtype within isinstance blocks, causing false positives. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The leading underscore made pyright treat the function as private to its module, causing reportPrivateUsage errors in commands.py and vumark.py. The _error_handling module name already signals it's package-internal. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Catching (UnknownTargetError, TargetStatusNotSuccessError) in a dedicated except clause means both types are already known to have target_id, so no pylint no-member suppressions are needed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
adamtheturtle
force-pushed
the
adamtheturtle/add-vumark-support
branch
from
f9d4bf8 to
112b0b0
Compare
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
|
||
| .. code-block:: console | ||
| $ docker run --rm --entrypoint vumark "ghcr.io/vws-python/vws-cli" --help |
There was a problem hiding this comment.
Missing scripts.vumark entry in pyproject.toml breaks Docker
High Severity
The documentation tells users to run docker run --rm --entrypoint vumark ..., but pyproject.toml is missing a scripts.vumark entry (only scripts.vws and scripts.vuforia-cloud-reco exist). The Docker image installs the package via uv pip install, which only creates console scripts declared in pyproject.toml. Without scripts.vumark = "vws_cli.vumark:generate_vumark", the vumark command won't exist in the Docker image or any pip-based installation, making all the Docker documentation and pip usage broken.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
vws generate-vumarkCLI command that wrapsVWS.generate_vumark_instance()from vws-python (VWS-Python/vws-python#2858). The command accepts a target ID, instance ID, and output format (PNG/SVG/PDF, defaulting to PNG), and writes the generated VuMark image bytes to a file.Error handling covers invalid instance IDs, targets not in the success state, unknown targets, and authentication failures. Tests use the existing
MockVWS/VuforiaDatabasefixtures and will pass once the vws-python PR is merged and the dependency is updated.🤖 Generated with Claude Code
Note
Medium Risk
Introduces a new CLI surface and expands the release pipeline to produce and attach additional binaries, which could affect packaging/release stability. Core VWS behavior isn’t modified; changes are mostly additive with test coverage.
Overview
Adds a new standalone
vumarkCLI command that callsVuMarkService.generate_vumark_instance, supports--format(png/svg/pdf), and writes the returned bytes to an output file with dedicated error handling for common VWS failures.Updates the release workflow to build/upload
vumarkPyInstaller binaries for Linux/Windows/macOS (while explicitly not publishing a WinGet package yet), and updates docs/README/help regression fixtures plus new tests and mock VuMark DB fixtures to cover the new command end-to-end.Written by Cursor Bugbot for commit a8c6497. This will update automatically on new commits. Configure here.